Add overlays for free-floating anchors on hovered/selected vector layers #2630
Conversation
|
Test cases: |
Keavon
changed the title
|
!build |
|
|
@0HyperCube Ready for review. |
editor/src/messages/portfolio/document/document_message_handler.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/utility_types/document_metadata.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/document_message_handler.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/overlays/utility_types.rs
Outdated
Show resolved
Hide resolved
|
See Discord comments. Marking as draft for the moment. Please mark as ready for review again once solved. Thanks :) |
|
!build |
|
|
Could you please make it work so when hovering over a point, it shows the overlays for the layer geometry, as it also does when hovering over a segment or filled shape? It looks like clicking those points works, but they're invisible until you actually click because hovering doesn't show it. I'm also observing a crash that is hard to reproduce. I'll keep trying to make it relicatable. |
|
I didn't understand what you meant specifically. I assume you meant that when you hover over a free-floating point on a layer that every shape on that layer also gets outlined, correct? If so, that does seems to work on my test cases. free_floating_points.mp4 |
There was a problem hiding this comment.
Crash might be due to this but, I am still unable to pinpoint what exactly is wrong with it:
https://github.com/GraphiteEditor/Graphite/pull/2630/files/e4f13954625fa5e1a8b2212c7850d18c8cfafe8f#diff-fe4d6f56fa9e774229baedb49b94d4dad31de3cd659209a538af1326e565f8f2R452-R456
seam0s-dev
force-pushed
the
2558-free-floating-anchors-overlays
branch
from
afe8075 to
139ac6f
Compare
Support for overlays as requested in #2558.